Open
Conversation
scorecard completion command generates completions for `scorecard`, instead of `./scorecard` command.
dovydenkovas
requested review from
justaugustus and
spencerschrock
and removed request for
a team
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
Now you could run:
and then use competion for installed scorecard:
What is the new behavior
Changed
./scorecardcommand in help message and completion toscorecard.Now you could run:
and then use competion for installed scorecard:
Which issue(s) this PR fixes
Fixes #5019
Special notes for your reviewer
It will break completion for users who put scorecard in local directory and run it from there.
Does this PR introduce a user-facing change?