Merged
Conversation
Member
|
@eddie-knight need to remove the |
Member
|
@eddie-knight add |
Member
|
Will this close #158 also? Can we update this PR description with |
Signed-off-by: Eddie Knight <knight@linux.com>
eddie-knight
force-pushed
the
fix/links
branch
from
e72706a to
dbd319c
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are issues with the links and a few other parts of the rendered schema. I copied over some changes that we made while working on the gemaraproj/gemara site, and tweaked it a bit more so it looks better overall.
There is a tradeoff in that it doesn't do things in the previous format such as
project.documentation.design. But the links work, and it matches the style of the gemara website.