Reduce pre-push hook to fast, non-network smoke tests#47
Merged
dreadn0ught merged 2 commits intoFeb 10, 2026
Conversation
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
Co-authored-by: dreadn0ught <31293924+dreadn0ught@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP Address feedback from review for testing improvements
Reduce pre-push hook to fast, non-network smoke tests
Feb 10, 2026
dreadn0ught
approved these changes
Feb 10, 2026
dreadn0ught
added a commit
that referenced
this pull request
Feb 10, 2026
* Improved testing and fixed poetry failure handling * add smoke tests * Add smoke tests to cicd * Update pre-push tests * fix tests * update runtime test paths * fix venv issue * Update .github/workflows/test.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ossprey/sbom_python.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/smoke/test_smoke.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Reduce pre-push hook to fast, non-network smoke tests (#47) * Initial plan * Update pre-push hook to run only fast, non-network smoke tests Co-authored-by: dreadn0ught <31293924+dreadn0ught@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dreadn0ught <31293924+dreadn0ught@users.noreply.github.com> * bug fix --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-push hook runs the full smoke suite including network-dependent tests (npm installs, git clones), making it slow and flaky for contributors without those tools.
Changes
smoke and not network and not slowtests (7 of 29 tests, ~22s)This excludes tests requiring external dependencies while maintaining coverage of core functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
High-level PR Summary
This is a work-in-progress PR created to address feedback from a review on PR #45. The PR is intended to merge into #45 rather than the main branch, and focuses on testing improvements based on specific review comments. Currently, no file changes have been submitted yet as the work is still in progress.
⏱️ Estimated Review Time: 5-15 minutes