Skip to content

Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow#48

Closed
dreadn0ught with Copilot wants to merge 2 commits into
update_testing_improve_poetryfrom
copilot/sub-pr-45-another-one
Closed

Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow#48
dreadn0ught with Copilot wants to merge 2 commits into
update_testing_improve_poetryfrom
copilot/sub-pr-45-another-one

Conversation

Copilot AI commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

test_existing_test_packages scans poetry fixtures in auto mode, triggering poetry install when poetry.lock is absent. This causes network/slow operations even when users filter those markers.

Changes:

  • poetry_simple_math: Generated and checked in poetry.lock with pinned dependencies (requests 2.26.0, numpy 2.0.0). Scanning no longer triggers poetry install.

  • poetry_broken_simple_math: Applied network and slow markers via pytest.param(). This fixture has an intentionally malformed pyproject.toml that cannot generate a valid lock file, so poetry install is unavoidable.

EXISTING_PACKAGES = [
    "python_simple_math",
    "poetry_simple_math",
    pytest.param(
        "poetry_broken_simple_math",
        marks=[pytest.mark.network, pytest.mark.slow]
    ),
    # ...
]

Test collection now respects marker filtering: -m "not network and not slow" skips poetry_broken_simple_math (5/6 collected), while unfiltered collection includes all 6 packages.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

High-level PR Summary

This is a work-in-progress PR created to address feedback from PR #45 regarding testing improvements in a poetry update. The PR is currently empty with no file changes, as it was just opened to track the feedback implementation work. It is intended to merge into PR #45 rather than directly into the main branch.

⏱️ Estimated Review Time: 5-15 minutes

Need help? Join our Discord

@recurseml recurseml Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 78239e9..d2f57cb

✨ No files to analyze

…math with network/slow

Co-authored-by: dreadn0ught <31293924+dreadn0ught@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on testing improvements in poetry update PR Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow Feb 10, 2026
Copilot AI requested a review from dreadn0ught February 10, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants