Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow#48
Closed
dreadn0ught with Copilot wants to merge 2 commits into
Closed
Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow#48dreadn0ught with Copilot wants to merge 2 commits into
dreadn0ught with Copilot wants to merge 2 commits into
Conversation
…math with network/slow Co-authored-by: dreadn0ught <31293924+dreadn0ught@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on testing improvements in poetry update PR
Check in poetry.lock for poetry_simple_math and mark poetry_broken_simple_math with network/slow
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_existing_test_packagesscans poetry fixtures in auto mode, triggeringpoetry installwhenpoetry.lockis absent. This causes network/slow operations even when users filter those markers.Changes:
poetry_simple_math: Generated and checked in
poetry.lockwith pinned dependencies (requests 2.26.0, numpy 2.0.0). Scanning no longer triggerspoetry install.poetry_broken_simple_math: Applied
networkandslowmarkers viapytest.param(). This fixture has an intentionally malformedpyproject.tomlthat cannot generate a valid lock file, sopoetry installis unavoidable.Test collection now respects marker filtering:
-m "not network and not slow"skipspoetry_broken_simple_math(5/6 collected), while unfiltered collection includes all 6 packages.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
High-level PR Summary
This is a work-in-progress PR created to address feedback from PR #45 regarding testing improvements in a poetry update. The PR is currently empty with no file changes, as it was just opened to track the feedback implementation work. It is intended to merge into PR #45 rather than directly into the main branch.
⏱️ Estimated Review Time: 5-15 minutes