Fix Task move-assignment to call request_stop before destroy#45
Merged
Conversation
Task::operator=(Task&&) was destroying the coroutine handle without
calling request_stop() first, unlike the destructor which correctly
calls request_stop() before handle.destroy(). This meant that any
registered stop_callbacks (e.g. TimerStream cancel, GoalStream cancel)
would never fire during move-assignment, leaving dangling coroutine
handles that could be resumed after the frame was destroyed.
This caused SIGBUS/SIGSEGV crashes when a Task holding a coroutine
suspended on TimerStream::next() was overwritten via move-assignment
(e.g. `task = Task<void>{}`), because the timer callback would later
resume the destroyed coroutine handle.
The fix adds handle.promise().stop_source.request_stop() before
handle.destroy() in operator=(Task&&) for both Task<T> and Task<void>,
matching the existing destructor behavior.
otamachan
force-pushed
the
fix-task-move-assign-request-stop
branch
from
09803e2 to
8931a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.