feat: Add reflink FileCopyMethod (copy-on-write)#166
Open
eth-p wants to merge 8 commits into
Open
Conversation
eth-p
force-pushed
the
feat-copymethod-reflink
branch
2 times, most recently
from
August 25, 2024 01:41
f225cea to
a812a19
Compare
eth-p
force-pushed
the
feat-copymethod-reflink
branch
5 times, most recently
from
September 14, 2024 20:58
2a79585 to
af89a8b
Compare
eth-p
marked this pull request as ready for review
September 14, 2024 20:58
eth-p
changed the title
eth-p
force-pushed
the
feat-copymethod-reflink
branch
from
September 14, 2024 21:04
af89a8b to
16a2a50
Compare
eth-p
force-pushed
the
feat-copymethod-reflink
branch
from
September 27, 2024 02:46
16a2a50 to
b87e8c9
Compare
When we add support for reflinks, we need to make sure we are able to check that regressions aren't introduced. Explicitly testing on different filesystems allows us to do that.
We want comprehensive testing, no matter the FileCopyMethod. Using an environment variable is a quick, clean, and easy way to do this.
The only `FileCopyMethod` that supports this is CopyBytes.
The only `FileCopyMethod` that supports this is CopyBytes.
eth-p
force-pushed
the
feat-copymethod-reflink
branch
from
September 27, 2024 06:07
b87e8c9 to
06711a6
Compare
otiai10
self-requested a review
October 8, 2024 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is stacked on top of #165. That must be reviewed and merged first.
Note
I'm calling it
reflinkbecause that's what Linux users understand it as.This brings copy-on-write file copying support as a
FileCopyMethod.Tests are passing: https://github.com/eth-p/forked-copy/actions/runs/10543146003/
TODO