Conversation
Final Budget App
Add live demo link
emmanuellekamwa
left a comment
There was a problem hiding this comment.
STATUS: CHANGES REQUESTED ⛔❌🛑
Hello @otmanTR 👋
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Descriptive PR.
- Good commit messages.
- Correct git-flow.
Required Changes ♻️
Check the comments under the review.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| ## Render Deploy 🚀 | ||
|
|
||
| [Live demo here](https://budgetapp-1jm2.onrender.com/) | ||
|
|
There was a problem hiding this comment.
- Your live demo link displays an error message when I click on it. Please kindly fix that.
FrederickMih
left a comment
There was a problem hiding this comment.
Hi 🙋 🙋 @otmanTR,
In my opinion, your project is ready for presentation! There is nothing else to say other than... it's time to merge it ![]()
Highlights 🟢
- Good commit history 👍
- Linter checks passed ✔️
Optional suggestions
- [We are always recommended to use Gitflow for solo projects so that changes should not be merged directly to the master branch when the app is approved.
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
| @@ -1,4 +1,4 @@ | |||
| ## Copyright 2021, [YOUR NAME] | |||
| ## Copyright 2021, [Recep Burak Otman] | |||
There was a problem hiding this comment.
- [Optional] Current date is obsolete. You didn't modify the date. It is recommended to update the date to the current year in order to render your License file professional
| <div class="d-flex flex-column text-center bg-white p-1 m-1"> | ||
| <%= form_with model: @group, url: groups_path do |form| %> | ||
| <div class="field"> | ||
|
|
||
| <%= form.text_field :name, placeholder: "Category Name", class: "form-control rounded-0" %> | ||
| </div> | ||
| <div> |

In this branch following changes done:
Splash screen
Sign up and log in pages
Home page (categories page)
Transactions page
"Add a new category" page
"Add a new transaction" page
Create unit and integration tests
Add styling with bootstrap