Skip to content

Budget App Final Part#3

Open
otmanTR wants to merge 37 commits intomasterfrom
dev
Open

Budget App Final Part#3
otmanTR wants to merge 37 commits intomasterfrom
dev

Conversation

@otmanTR
Copy link
Copy Markdown
Owner

@otmanTR otmanTR commented Jun 8, 2023

In this branch following changes done:

  • Splash screen

    • A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.
  • Sign up and log in pages

    • The user should be able to register in the app with full name, email and password (all mandatory).
    • The user can log into the app using email and password.
    • If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).
  • Home page (categories page)

    • When the user logs in, they are presented with the categories page.
    • For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
    • When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
    • There is a button "add a new category" at the bottom that brings the user to the page to create a new category.
  • Transactions page

    • For a given category, the list of transactions is presented, ordered by the most recent.
    • At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
    • There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new category" page

    • The user fills out a form to create a new category, indicating their name and icon (both mandatory).
    • The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new transaction" page

    • The user fills out a form to create a new transaction with:
      • name (mandatory)
      • amount (mandatory)
      • categories (mandatory at least one)
    • The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
    • When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.
  • Create unit and integration tests

  • Add styling with bootstrap

@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 12:21 — with GitHub Pages Inactive
Copy link
Copy Markdown

@emmanuellekamwa emmanuellekamwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUESTED ⛔❌🛑
Hello @otmanTR 👋
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Descriptive PR.
  • Good commit messages.
  • Correct git-flow.

Required Changes ♻️

Check the comments under the review.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment thread README.md
## Render Deploy 🚀

[Live demo here](https://budgetapp-1jm2.onrender.com/)

Copy link
Copy Markdown

@emmanuellekamwa emmanuellekamwa Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your live demo link displays an error message when I click on it. Please kindly fix that.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 14:10 — with GitHub Pages Inactive
@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 14:11 — with GitHub Pages Inactive
@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 17:15 — with GitHub Pages Inactive
@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 17:25 — with GitHub Pages Inactive
@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 17:36 — with GitHub Pages Inactive
@otmanTR otmanTR temporarily deployed to github-pages June 8, 2023 17:43 — with GitHub Pages Inactive
Repository owner deleted a comment from netlify Bot Jun 8, 2023
Copy link
Copy Markdown

@FrederickMih FrederickMih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 🙋 🙋 @otmanTR,

In my opinion, your project is ready for presentation! There is nothing else to say other than... it's time to merge it :shipit:

Highlights 🟢

  • Good commit history 👍
  • Linter checks passed ✔️

Optional suggestions

  • [We are always recommended to use Gitflow for solo projects so that changes should not be merged directly to the master branch when the app is approved.

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Comment thread MIT.md
@@ -1,4 +1,4 @@
## Copyright 2021, [YOUR NAME]
## Copyright 2021, [Recep Burak Otman]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [Optional] Current date is obsolete. You didn't modify the date. It is recommended to update the date to the current year in order to render your License file professional

Comment on lines +18 to +24
<div class="d-flex flex-column text-center bg-white p-1 m-1">
<%= form_with model: @group, url: groups_path do |form| %>
<div class="field">

<%= form.text_field :name, placeholder: "Category Name", class: "form-control rounded-0" %>
</div>
<div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [Optional] For a great user experience, kindly make sure that all input fields are visible. As seen in the screenshot below, the category name input field is not visible.
    Screenshot from 2023-06-08 19-15-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants