Skip to content

Final Project#20

Open
otmanTR wants to merge 51 commits intomasterfrom
dev
Open

Final Project#20
otmanTR wants to merge 51 commits intomasterfrom
dev

Conversation

@otmanTR
Copy link
Copy Markdown
Owner

@otmanTR otmanTR commented Jun 1, 2023

In this branch following changes done:

  • Login page and registration page:
    • Should be built with Devise.
  • Food list :
    • Should display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).
    • Should lead to a form that allows users to add new food.
  • Recipes list:
    • Should display a list of recipes created by the logged-in user as in the wireframe.
    • Should lead to recipe details.
    • If the user is the owner of the recipe, should allow the user to delete it.
  • Public recipe list:
    • Should display a list of all public recipes ordered by newest as in the wireframe.
    • Should lead to recipe details.
  • Recipe details:
    • Should display a toggle button that allows for a recipe to be made public or private.
    • If the recipe is public or the user is the owner of the recipe, should display the recipe details as in the wireframe.
    • If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
  • General shopping list view (only for a group that has less than 3 members):
    • Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).
    • Should count the total food items and total price of the missing food.
  • Check there are no N+1 queries happening.
  • Create a navigation menu that allows users to open all of the pages you created.
  • Write unit and integration tests
  • Set up the repository on GitHub and use Gitflow.
  • Set up Devise for authentication.
  • Set up RSpec and Capybara testing libraries.

Copy link
Copy Markdown

@mahbubul14 mahbubul14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Approved 🏆 🎉

Hi @otmanTR & @HanaSabih ,

Your project is complete! You have done it exceptionally well. it's time to merge it 💯
Congratulations! 🎉

To Highlight 👍

✔️ No linter error.
✔️ Descriptive readme file.
✔️ Well-implemented CRUD.

Optional suggestions 🔽

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also connect with me on slack


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants