Conversation
Author
|
Right now, the immediate issue I am working on in this branch is to make it so that if there is a custom agent created by the ACE editor but it is not selected in the config, it should not be sent to the backend. Right now, based on the current state of the front and back end versions of ACE editor, it runs with custom plants, but if and only if the agents specified in the agent editor are also added as plants in the config. |
Author
|
I have modified front_end_routes.py such that if a custom plant is in local storage (i.e. added via the ACE editor) but not selected from the setup wizard to start the simulation, that custom plant is removed from the configuration. This prevents the simulation from crashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft pull request for back end changes needed to support the ACE agent editor.
Right now it still needs to be hardcoded for plants to work and it may not support other kinds of agents besides plants properly.
It also contains debugging app logger comments that will be removed before the actual pull, EDIT: And apparently some comments I left on the code trying to figure it out that I need to scrub away!