Skip to content

Support multiple Docker deployments on the same host#586

Draft
ezio-melotti wants to merge 5 commits intomasterfrom
docker-multiple-deployments
Draft

Support multiple Docker deployments on the same host#586
ezio-melotti wants to merge 5 commits intomasterfrom
docker-multiple-deployments

Conversation

@ezio-melotti
Copy link
Collaborator

This is another attempt at supporting multiple Docker deployment on the same host.
The first attempt was:

@ezio-melotti ezio-melotti requested a review from Copilot December 3, 2025 09:11
@ezio-melotti ezio-melotti self-assigned this Dec 3, 2025
@ezio-melotti ezio-melotti added infrastructure Docker, GCP, GitHub actions, etc. enhancement An enhancement for an existing feature labels Dec 3, 2025

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)
parser.add_argument(
'--env-file', metavar='FILE', type=pathlib.Path,
help='the env file with the deployment-specific variables'
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text for --env-file no longer mentions that there's a default value of env/local.env. Consider updating the help text to inform users about the default behavior, e.g., help='the env file with the deployment-specific variables (default: env/local.env)'

Suggested change
help='the env file with the deployment-specific variables'
help='the env file with the deployment-specific variables (default: env/local.env)'

Copilot uses AI. Check for mistakes.
Comment on lines 433 to 434
# mount the 'simoc_db-testing' volume instead of the
# default 'simoc_db-data' if 'testing' is passed as arg
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references hardcoded volume names 'simoc_db-testing' and 'simoc_db-data', but the actual volume names are now dynamic based on PROJECT_NAME. Consider updating the comment to reflect this, e.g., "mount the '{PROJECT_NAME}_db-testing' volume instead of the default '{PROJECT_NAME}_db-data' if 'testing' is passed as arg"

Suggested change
# mount the 'simoc_db-testing' volume instead of the
# default 'simoc_db-data' if 'testing' is passed as arg
# mount the '{PROJECT_NAME}_db-testing' volume instead of the
# default '{PROJECT_NAME}_db-data' if 'testing' is passed as arg

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement for an existing feature infrastructure Docker, GCP, GitHub actions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants