Support multiple Docker deployments on the same host#586
Support multiple Docker deployments on the same host#586ezio-melotti wants to merge 5 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| parser.add_argument( | ||
| '--env-file', metavar='FILE', type=pathlib.Path, | ||
| help='the env file with the deployment-specific variables' |
There was a problem hiding this comment.
The help text for --env-file no longer mentions that there's a default value of env/local.env. Consider updating the help text to inform users about the default behavior, e.g., help='the env file with the deployment-specific variables (default: env/local.env)'
| help='the env file with the deployment-specific variables' | |
| help='the env file with the deployment-specific variables (default: env/local.env)' |
| # mount the 'simoc_db-testing' volume instead of the | ||
| # default 'simoc_db-data' if 'testing' is passed as arg |
There was a problem hiding this comment.
The comment references hardcoded volume names 'simoc_db-testing' and 'simoc_db-data', but the actual volume names are now dynamic based on PROJECT_NAME. Consider updating the comment to reflect this, e.g., "mount the '{PROJECT_NAME}_db-testing' volume instead of the default '{PROJECT_NAME}_db-data' if 'testing' is passed as arg"
| # mount the 'simoc_db-testing' volume instead of the | |
| # default 'simoc_db-data' if 'testing' is passed as arg | |
| # mount the '{PROJECT_NAME}_db-testing' volume instead of the | |
| # default '{PROJECT_NAME}_db-data' if 'testing' is passed as arg |
This is another attempt at supporting multiple Docker deployment on the same host.
The first attempt was: