Reuse cache entries for identical file contents#236
Merged
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
Collaborator
|
Confirmed by running your code in real conditions too ! First Runbin/phplint lint tests/Cache/Fixtures/releases/ --extensions fixture -vvSecond Runbin/phplint lint tests/Cache/Fixtures/releases/ --extensions fixture -vvGreat Job @StantonMatt |
llaville
pushed a commit
that referenced
this pull request
Jun 3, 2026
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224.
This changes readable file cache keys to use the file fingerprint instead of the path-derived key, so identical files copied into separate release directories can share the same cache entry. The existing sanitized path key remains as the fallback for unreadable or unknown paths.
Tests:
docker run --rm -v "$PWD:/app" -w /app composer:2 vendor/bin/phpunit --no-progress --testdox --do-not-cache-result --testsuite cachedocker run --rm -v "$PWD:/app" -w /app composer:2 vendor/bin/phpunit --no-progress --testdox --do-not-cache-resultgit diff --check