feat(editor): add multi-buffer find-file#57
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b60c1ba225
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a186f6fe64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 540dd69ff2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0788df933
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
C-x C-faccept existing files, missing files, and directoriesC-x bswitching by exact path or unique file nameWhy
Cortex could create a missing path through the CLI or
/open, butC-x C-fonly exposed existing picker entries and replacing the current buffer could discard workflow context. This adds the Emacs-shaped find-file and buffer switching behavior requested in issue #30.Acceptance proof
C-x C-faccepts existing, missing, whitespace-bearing, and directory paths: covered by app and editor tests.C-x bswitches by exact path or unique file name and reports ambiguity: covered by keymap, app, and editor tests.Test plan
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo test(155 passed)git diff --check/tmp/cortex-issue-30-smoke-created.txt, switched back toREADME.md, exited with status 0, and verified terminal cleanup.throughC-x C-f, confirmed the directory picker opened, canceled back to the buffer, and exited with status 0Risks
Path identity now resolves the nearest existing ancestor so relative and absolute aliases for missing files share one buffer. The switch prompt currently requires an exact path or unique file name and has no completion.
Related issue
Closes #30