Improve Installation Script Robustness and Compliance

[matbrgz]

Overview

This pull request introduces significant improvements to the installation script for bum. The modifications focus on increasing robustness, security, and maintainability while ensuring the script adheres to ShellCheck recommendations and providing a more user-friendly experience.

Key Changes

• Helper Functions:

  • Added error(), info(), and info_bold() functions to standardize error handling and logging.

• Dependency Checks:

  • Incorporated checks for essential commands (bun, curl, tar, uname, mkdir, mv, rm) to ensure all dependencies are met before execution.

• Bun Installation:

  • Added logic to automatically install Bun if it's not already available on the system.

• Architecture Detection:

  • Improved system architecture detection using uname -ms with a robust case statement to correctly set the target platform.

• Download and Extraction Enhancements:

  • Downloads the compressed executable using curl with progress feedback.
  • Extracts the tarball into a temporary directory using mktemp and sets a trap to guarantee cleanup in case of errors.
  • Moves the executable into the designated installation directory and ensures proper cleanup of temporary files.

• ShellCheck Compliance:

  • Applied ShellCheck recommendations by guarding variables in the rm -rf command using ${var:?} to prevent dangerous expansions.
  • Modified the tildify function to correctly handle tilde expansion by quoting variable expansions appropriately.

• Environment Configuration:

  • Added a modular function add_commands_to_file to append environment variable configuration to the user's shell configuration file (supports Fish, Zsh, and Bash).
  • Provides clear instructions for manual configuration if automatic file modification is not possible.
  • Displays a refresh command to help users update their shell environment immediately.

Impact

These changes make the installation script:

• More Robust: Handles errors gracefully and prevents accidental removal of system directories.
• More Secure: Verifies dependencies and uses temporary directories to minimize risks.
• More User-Friendly: Provides clear feedback and instructions, improving the overall installation experience.
• Maintainable: Modular code structure and standardized logging simplify future updates and troubleshooting.

Feel free to review the changes and provide feedback.

[owenizedd]

Did you test this change?
And can you tell me which change fix the bugs?

[owenizedd]

this is contradictory with line 18 no? you check bun here but will never reach line 18 (installing bun)

[matbrgz]

My fault. Fixing it.

[owenizedd]

I see that you added the info, I took this as reference from bun repo and I already push it to main for that particular code, however other improvements looks good if you updated it and tested to be working fine.