build(deps): bump com.android.tools.build:gradle from 8.7.2 to 9.2.1#4865
build(deps): bump com.android.tools.build:gradle from 8.7.2 to 9.2.1#4865dependabot[bot] wants to merge 1 commit into
Conversation
b548d49 to
5fa7719
Compare
|
@dependabot rebase |
5fa7719 to
8b6d21b
Compare
Bumps com.android.tools.build:gradle from 8.7.2 to 9.2.1. --- updated-dependencies: - dependency-name: com.android.tools.build:gradle dependency-version: 9.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8b6d21b to
b24185f
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Review: AGP 8.7.2 → 9.2.1 (MAJOR build-system bump) — DeepDiver1975, maintainer review.
This is a one-line bump of the Android Gradle Plugin major version (8.x → 9.x), i.e. the core of the build toolchain. CI is red, which is the decisive signal here:
Run Android Unit Tests— failRun Android Instrumented Data Tests— failDetekt— fail
(Validation, string-validation and semantic-commit checks pass, but those don't compile the project.)
Root cause / migration risk — Gradle version floor. The repo pins the wrapper to Gradle 8.9 (gradle/wrapper/gradle-wrapper.properties → gradle-8.9-bin.zip). AGP 9.x requires Gradle 9.x; AGP 8.7 was the last line that ran on Gradle 8.9. So this bump cannot build until the wrapper is upgraded to a Gradle 9.x release first. That alone explains the failing build/test jobs.
Other AGP 9 migration concerns to verify before this can go green (not addressable by a version-only bump):
- JDK: CI runs JDK 17 (
detekt.ymletc.). AGP 9 requires JDK 17 as the minimum to run Gradle — OK at 17, but worth confirming all jobs are on 17+. - Removed/changed DSL: AGP 9 removes long-deprecated DSL and the legacy Variant API, and tightens namespace requirements. The build uses Groovy DSL with
buildscript{}classpath wiring (build.gradle) plus KSP/ktlint/detekt/sonarqube/cyclonedx plugins applied to all subprojects — each plugin must have an AGP-9-compatible version, and any removed DSL must be migrated. - AGP–KGP coupling: AGP 9 changes how the Kotlin plugin integrates; the Kotlin Gradle Plugin version (
libs.kotlin.gradlePlugin) likely needs a coordinated bump.
Verdict: changes requested. A major build-system jump is not a safe version-only Dependabot bump for this repo. It needs a deliberate migration PR: bump the Gradle wrapper to 9.x, audit the third-party Gradle plugins for AGP-9 compatibility, migrate any removed DSL, and only land once all build/test checks are green. As-is the change does not build.
Recommend: hold (or close in favour of a dedicated AGP-9 migration effort). Not merging from here.
🤖 Generated with Claude Code
Bumps com.android.tools.build:gradle from 8.7.2 to 9.2.1.