test: enhance the Storage directory test output#41692
Open
phil-davis wants to merge 1 commit into
Open
Conversation
This unit test has a lot of assertions about the directory-under-test as it is created, deleted etc. Currently, if the test fails then there is just a message like "Failed asserting that false is true." This change adds descriptive messages for each unit test assertion. That will make it easier to know at which step the test failed. Signed-off-by: Phillip Davis <phil@jankaritech.com>
Contributor
Author
|
This will help when running unit tests in various storage apps that run these directory tests against various different storages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unit test has a lot of assertions about the directory-under-test as it is created, deleted etc. Currently, if the test fails then there is just a message like "Failed asserting that false is true."
This change adds descriptive messages for each unit test assertion. That will make it easier to know at which step the test failed.
Test change only, changelog is not required.
I was looking at unit test results of owncloud/files_external_s3#1048
https://github.com/owncloud/files_external_s3/actions/runs/29474921414/job/87545790764?pr=1048
Results like this are not helpful: