Skip to content

fix: return null instead of false in case of invalid quota #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvillafanez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: return null instead of false in case of invalid quota #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/User/UserEntry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public function getDisplayName() {
* values are 'none' (unlimited), 'default' (the ownCloud's default quota), '1234' (quota in
* bytes), '1234 MB' (quota in MB - check the \OC_Helper::computerFileSize method for more info)
*
* @return string|false quota
* @return string|null quota
* TODO throw Exception for invalid values after https://github.com/owncloud/core/pull/28805 has been merged
*/
public function getQuota() {
Expand Down Expand Up @@ -238,9 +238,6 @@ public function getQuota() {
}
}
}
if ($quota === null) {
$quota = false;
}

\OC::$server->getLogger()->debug("using quota <$quota> for user <{$this->getOwnCloudUID()}>", ['app' => 'user_ldap']);
return $quota;
Expand Down