Skip to content

[full-ci] chore: [OCISDEV-790] add ci-full flag#13728

Merged
mzner merged 1 commit into
masterfrom
feat/OCISDEV-790/add-full-ci-flag
May 15, 2026
Merged

[full-ci] chore: [OCISDEV-790] add ci-full flag#13728
mzner merged 1 commit into
masterfrom
feat/OCISDEV-790/add-full-ci-flag

Conversation

@mzner
Copy link
Copy Markdown
Contributor

@mzner mzner commented May 4, 2026

Description

Introduces a check-flags job to the GitHub Actions test workflow that gates downstream jobs based on changed file paths and an opt-in full-ci flag in the PR title.

Changes:

  • New check-flags job runs before all other jobs and produces three outputs:
    • full-ci: true when the PR title contains full-ci (case-insensitive)
    • ci-relevant: true when files relevant to CI (packages, tests, config files, etc.) were changed
    • affected-suites: the subset of test suites affected by the changed files, determined via filterTestSuitesToRun.js
  • The build job is now skipped on PRs when no CI-relevant files changed and full-ci is not set
  • The e2e-playwright job skips individual test suites when they are not in the affected suites list
  • Two suites (app-provider, ocm) are marked requires_full_ci: true and only run when full-ci is explicitly requested
  • check-tests-passed now also depends on build

Related Issue

Motivation and Context

CI runs on every PR are time-consuming and resource-intensive. Previously all jobs ran regardless of which files were changed. This change makes jobs conditional on the actual changes in the PR, while providing a full-ci opt-in in the PR title for cases where complete coverage is required.

How Has This Been Tested?

  • test environment: GitHub Actions (PR workflow)
  • test case 1: PR with no CI-relevant file changes → build and e2e-playwright jobs are skipped
  • test case 2: PR with changes to source packages → only affected test suites are executed
  • test case 3: PR title includes full-ci → all jobs and suites run unconditionally
  • test case 4: Push/tag event → all jobs run as before

Screenshots (if appropriate):

N/A

@mzner mzner requested a review from LukasHirt May 4, 2026 07:20
@update-docs
Copy link
Copy Markdown

update-docs Bot commented May 4, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch from 2e85e63 to c2a9145 Compare May 4, 2026 07:36
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In drone, we were using filterTestSuitesToRun.js to find what tests should run. If you find the current approach works better I am fine with not using that but I would:

  1. check whether the result is the same
  2. if it won't be used anymore, delete it

Also, if we go with this approach, the GH action needs to be whitelisted.

Comment thread .github/workflows/test.yml Outdated
@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch from c2a9145 to 7aa763f Compare May 6, 2026 08:58
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is still some action needing to be whitelisted.

@mzner
Copy link
Copy Markdown
Contributor Author

mzner commented May 12, 2026

Seems like there is still some action needing to be whitelisted.

I'm waiting for your approval here first before asking Thomas to white list it.

@LukasHirt
Copy link
Copy Markdown
Collaborator

I'm waiting for your approval here first before asking Thomas to white list it.

It would be best to first see the CI running here to see whether it works as expected. I would approve the code as it is now but waiting for the successful run is necessary.

@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch 2 times, most recently from 53ce230 to 728e7af Compare May 12, 2026 10:35
@mzner mzner changed the title chore: [OCISDEV-790] add ci-full flag [full-ci] chore: [OCISDEV-790] add ci-full flag May 12, 2026
@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch from 728e7af to 8cb6669 Compare May 12, 2026 13:07
@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch 2 times, most recently from 642827f to 7cac4e5 Compare May 15, 2026 07:41
@mzner
Copy link
Copy Markdown
Contributor Author

mzner commented May 15, 2026

@PrajwolAmatya Could you please confirm the changes in this commit? Some of the latest changes we have in this commit "9bd7e30" broke the ci cause the filter test js file was not updated.

Comment thread tests/drone/filterTestSuitesToRun.js Outdated
@mzner mzner force-pushed the feat/OCISDEV-790/add-full-ci-flag branch from 7cac4e5 to fac5d88 Compare May 15, 2026 08:29
@sonarqubecloud
Copy link
Copy Markdown

@mzner mzner merged commit 6299469 into master May 15, 2026
18 checks passed
@mzner mzner deleted the feat/OCISDEV-790/add-full-ci-flag branch May 15, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants