chore: update packageManager to pnpm 11.0.4#592
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca41e19ae3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "delegating bare-specifier resolve with custom conditions: {}", | ||
| specifier | ||
| ); | ||
| return next_resolve.call((specifier, None).into()); |
There was a problem hiding this comment.
Keep path-alias resolution for bare imports with conditions
This early return skips oxc-resolver entirely for any bare specifier when a custom condition is present, which drops support for tsconfig paths aliases in exactly the scenario introduced by this commit (--conditions=dev in packages/integrate-module-bundler/package.json). For example, packages/integrate-module-bundler/src/index.ts imports @subdirectory/bar, and that alias is only defined in packages/integrate-module-bundler/tsconfig.json; delegating directly to Node here causes Node to treat it as an external package name and fail resolution.
Useful? React with 👍 / 👎.
Summary
pnpm@11.0.4