Skip to content

chore: update packageManager to pnpm 11.0.4#592

Open
Boshen wants to merge 6 commits into
mainfrom
chore/pnpm-11-0-4
Open

chore: update packageManager to pnpm 11.0.4#592
Boshen wants to merge 6 commits into
mainfrom
chore/pnpm-11-0-4

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented May 12, 2026

Summary

  • update the pnpm package manager pin to pnpm@11.0.4
  • add missing pnpm package manager metadata where needed
  • keep lockfiles unchanged to avoid unrelated dependency updates

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca41e19ae3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib.rs Outdated
"delegating bare-specifier resolve with custom conditions: {}",
specifier
);
return next_resolve.call((specifier, None).into());
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep path-alias resolution for bare imports with conditions

This early return skips oxc-resolver entirely for any bare specifier when a custom condition is present, which drops support for tsconfig paths aliases in exactly the scenario introduced by this commit (--conditions=dev in packages/integrate-module-bundler/package.json). For example, packages/integrate-module-bundler/src/index.ts imports @subdirectory/bar, and that alias is only defined in packages/integrate-module-bundler/tsconfig.json; delegating directly to Node here causes Node to treat it as an external package name and fail resolution.

Useful? React with 👍 / 👎.

@Boshen Boshen force-pushed the chore/pnpm-11-0-4 branch from 4e4b0a5 to 107e56d Compare May 14, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant