DIGIT-2819 Add Rack Stack span and normalize Queue Time span type/subtype#4
Conversation
🤖 GitHub commentsJust comment with:
|
| "rack-stack": { | ||
| "__description": "Time spent in Rack stack before being handled by GraphQL", | ||
| "__used_by": [ | ||
| "ruby" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Is this the time between the request leaves nginx and starts to be process by rails, right? This probably is also the time that the request lays on puma queue, not only the rack stack.
There was a problem hiding this comment.
Actually, queue-time measure nginx+puma queue, while rack-stack only starts after puma dequeue, the correct flow bellow:
enter nginx -> start queue-time -> nginx route to puma -> puma queue -> puma processing -> puma dequeue -> stop queue-time -> start rack-stack -> call rack -> ...rack middlewares -> stop rack-stack -> start GrapqhController span -> start GraphqlController#execute span -> ...
The previous subtype descriptions left room for misinterpretation, so I updated them to make this distinction explicit (and clarified queue-time as well)
Uh oh!
There was an error while loading. Please reload this page.