[sled-agent] Vectorize the request for dataset zones#3025
Closed
smklein wants to merge 5 commits intodns-datasetfrom
Closed
[sled-agent] Vectorize the request for dataset zones#3025smklein wants to merge 5 commits intodns-datasetfrom
smklein wants to merge 5 commits intodns-datasetfrom
Conversation
smklein
added a commit
that referenced
this pull request
Jun 29, 2023
…oo (#3390) ## Prelude This combines: - #3022 - #3025 - #3026 Into one PR. Trying to split them out resulted in intermediate states that were not worthwhile debugging - I'd rather invest the energy into fixing this "more-desirable end-state". ## What does this PR do - (Internal and External) DNS services are explicitly backed by datasets, making it possible to "delete and re-initialize" arbitrary zones without data loss. This is necessary for correct behavior in cold boot. - Merges the concept of "datasets" into "services". - Previously, "datasets" were considered services managing data, and "services" were considered services *without datasets* - the two were totally disjoint. This was a bit arbitrary, and made it more complicated to conform sleds during service management. - As one example of an inconsistency, "requesting services" was vectorized ("ask for all services that should be on the sled"), "requesting datasets" was not (it was an ask-for-one-at-a-time API). - Now, "services" are universal, and they may optionally manage datasets. This unifies pathways a bit, and simplifies the API. Fixes #3018 Part of #2978
Collaborator
Author
|
Merged in #3390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to unify the interface between "storage" and "non-storage" zones.
Part of #2978