Merged
Conversation
Collaborator
Author
|
Reproduced the problem: Here's the fixed binary: |
sunshowers
approved these changes
Oct 21, 2025
Contributor
There was a problem hiding this comment.
Looks good.
Reasoning for myself: What happens if we were in the middle of a write operation and stdout goes away?
- Today, we'd panic, which would abort, dropping the connection.
- With this change, omdb would receive SIGPIPE and terminate immediately, dropping the connection.
In either case, what happens differs by the service being hit. If it's a Dropshot service, it would be run to completion (we don't cancel futures on connection drop). If it's a database connection, the transaction would be aborted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8352 in the same way as #5358 fixed
oxlog.