Use pki-playground api in tls/build.rs#104
Merged
Merged
Conversation
flihp
force-pushed
the
pki-playground-api
branch
2 times, most recently
from
July 9, 2026 22:44
5b852b1 to
40a2dbb
Compare
flihp
force-pushed
the
pki-playground-api
branch
from
July 13, 2026 01:19
40a2dbb to
68d2fee
Compare
Collaborator
Author
|
This is a sort of minimal implementation that leaves the current approach in place: build.rs still generates files through pki-playground and the tests still read these files from disk as inputs. Using the API gets us the explicit dependencies on pki-playground through cargo as wanted by #89, but we should consider having the test cases generate their inputs independent of a build.rs so we don't have to rely on the |
labbott
approved these changes
Jul 14, 2026
labbott
left a comment
labbott
left a comment
Contributor
There was a problem hiding this comment.
LGTM I think this is a definite improvement. Sometime it could be useful to talk to people who've done a lot of work on omicron and testing to see if they have other ideas.
andrewjstone
approved these changes
Jul 14, 2026
andrewjstone
left a comment
andrewjstone
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Phil. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.