Fix latent clippy lints surfaced by --all-targets on illumos#109
Open
plaidfinch wants to merge 1 commit into
Open
Fix latent clippy lints surfaced by --all-targets on illumos#109plaidfinch wants to merge 1 commit into
plaidfinch wants to merge 1 commit into
Conversation
cargo clippy --all-targets -- -D warnings fails on illumos (where the cfg(target_os) build-script lines and the unittest build path compile) on lints the ubuntu CI run never sees: uninlined format args in build.rs and a needless Ok(..?) wrapper, plus roots.len() < 1 in both examples. Inline the format args, drop the wrapper, and use is_empty(). No behavior change.
This was referenced Jul 17, 2026
plaidfinch
marked this pull request as ready for review
July 17, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAVEAT LECTOR: This PR was generated by Claude Fable 5.
cargo clippy --all-targets -- -D warningsfails on illumos — where thecfg(target_os = "illumos")build-script lines and theunittestbuild path actually compile — on lints the ubuntu CI run never sees:build.rs(theOXIDE_PLATFORMlink lines, and the mock-log message introduced in More complete measurement verification #106's build-script rework) and aneedless_question_markOk(..?)wrapper aroundfs::writeargs.roots.len() < 1instead ofis_empty()in both examplesPure lint fixes; no behavior change.
Verified on illumos:
cargo clippy --all-targets -- -D warningsclean,cargo test6/6.Relationships
Independent of #107 and #108; the three can land in any order.