Conversation
|
It looks like this was included in the release based on the pin in |
Collaborator
|
looks like this got left behind in the fray. Same w/ oxidecomputer/dice-util#360. the dice-verifier changes were approved ~2 weeks ago so the merge button just didn't get pressed. I can do that easy enough. Will circle back on this one once that builds green. |
Member
Author
|
clicked the button on dice-util#360 and bumped to the now-green commit with that over there: oxidecomputer/dice-util@d7472bf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairs with dice-util#360. this is pretty small in comparison. most of the volume here is because I moved the tests to
tokio::testnow that they do.awaits, and that means we now have a dev-dependency on tokio.