Skip to content

🔨 add a local dev environment - #83

Merged
garak merged 2 commits into
p-chess:masterfrom
garak:local-docker
May 14, 2026
Merged

🔨 add a local dev environment#83
garak merged 2 commits into
p-chess:masterfrom
garak:local-docker

Conversation

@garak

@garak garak commented May 13, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 13, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Docker-based local development environment and documents how to use it to build, run, and execute common quality checks for the PHP chess library.

Changes:

  • Added “Local development” documentation to the README.
  • Introduced a Makefile with helper targets for Docker Compose, Composer, PHPUnit, PHPStan, and PHP-CS-Fixer.
  • Added Docker Compose + a PHP CLI Dockerfile for running the project in containers, and excluded Docker assets from export archives.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
README.md Documents Docker/Make-based local development workflow and common commands.
Makefile Adds developer targets for build/start/install/test/stan/cs/coverage/etc. via Docker Compose.
docker/Dockerfile Defines a PHP CLI image with Composer and pcov for running tools inside Docker.
docker-compose.yaml Defines a php service for running commands against the mounted working tree.
.gitattributes Excludes Docker-related dev environment files from distribution exports.
Comments suppressed due to low confidence (1)

Makefile:4

  • The args = ... variable is currently unused anywhere in this Makefile. If argument forwarding isn’t needed, it should be removed; otherwise, wire it into the relevant targets so it’s clear how callers should pass arguments.
args = `arg="$(filter-out $@,$(MAKECMDGOALS))" && echo $${arg:-${1}}`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread docker/Dockerfile Outdated
Comment thread docker/Dockerfile Outdated
Comment thread docker-compose.yaml
Comment thread README.md
@garak
garak merged commit c1ffc3d into p-chess:master May 14, 2026
5 checks passed
@garak
garak deleted the local-docker branch May 14, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants