Don't set obsolete y-fill property for icons#151
Open
real-or-random wants to merge 1 commit intop-e-w:masterfrom
Open
Don't set obsolete y-fill property for icons#151real-or-random wants to merge 1 commit intop-e-w:masterfrom
real-or-random wants to merge 1 commit intop-e-w:masterfrom
Conversation
No replacement seems to be necessary. My testing shows that no stretching is performed anyway. Fixes p-e-w#146.
Author
|
Note that the surrounding code still doesn't do exactly what it's supposed to do (see #145), but I have no idea how to fix this. |
Collaborator
|
Any idea when / with which GNOME version this property has become obsolete? #174 is a similar PR which adds a "replacement" which is probably a no-op, but who knows if that applies to all environments. I'd prefer that if it's ok for you. |
Author
|
I have no idea, except that I can look at the date when I opened this PR. If you feel that #174 is a safer alternative, then sure, let's pick that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No replacement seems to be necessary. My testing shows that no stretching is performed anyway.
Fixes #146.