Bump CMake version and fix warning on arm64#158
Open
zhao-shihan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build configuration and improves Unicode handling in the codebase. The main changes are an update to the minimum required CMake version and a fix to use the correct type for Unicode interval boundaries.
Build system update:
projectconfiguration inCMakeLists.txt. 3.8 is ancient.Fix a compilation warning on ARM64:
interval::firstandinterval::lastfrominttowchar_tin bothinclude/indicators/display_width.hppandsingle_include/indicators/indicators.hpp. This fixes the following warning on ARM64:That's because
wchar_tcan be either signed or unsigned, depending on platform and compilation options.