Merged
Conversation
421cfbb to
2267755
Compare
2267755 to
727661d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the performance and correctness of the
__getitem__method inAccessorPathby optimizing traversal logic, and adds comprehensive tests and benchmarks to verify and measure these improvements.Core logic and performance improvements
AccessorPath.__getitem__method inpathable/paths.pyto minimize redundant traversals and improve efficiency by using direct traversal helpers when available, with compatibility fallbacks for other accessors.Testing enhancements
CountingTraversableAccessorclass intests/unit/test_paths.pyto track the number of traversal operations, enabling precise testing of traversal efficiency.TestAccessorPathGetItemPerformanceto ensure that only a single traversal occurs when accessing a leaf value, validating the performance improvement.Benchmarking
tests/benchmarks/bench_lookup.pyto include benchmarks for__getitem__operations on both leaf and branch nodes, allowing performance measurement of the new logic.Type consistency
MockTraversableAccessorto useMapping[Any, Any]for improved consistency and generality in tests.