Conversation
6eb26fc to
63b7f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
parse_partsfunction inpathable/parsers.pyto improve performance and readability. The most important changes are grouped below:Performance and readability improvements:
int,str, andbytestypes to reduce unnecessary checks and improve efficiency; now, integers are appended directly, strings are checked and split only if needed, and bytes are decoded before processing.parsed.appendwith a localappendvariable for cleaner and slightly faster code.TypeError.These changes make the function more efficient and easier to follow, especially when handling common input types.
Benchmarks: