Improved handling of comic book archive and other archive formats#574
Improved handling of comic book archive and other archive formats#574omega-fallon wants to merge 17 commits intop2r3:masterfrom
Conversation
…nd weight to ensure image->image archive is always picked first over nonsense options
src/TraversionGraph.ts
Outdated
| {from: "image", to: "image archive", cost: -1}, // Prioritize immensely | ||
| {from: "image archive", to: "image archive", cost: -2}, // Prioritize more |
There was a problem hiding this comment.
Firstly, not a fan of negative weights. There's almost certainly a better way to accomplish whatever this is doing.
Secondly, can you explain why you had to do this? You really shouldn't mess with weights unless absolutely necessary. I suspect that this is "patching" some problem, rather than fixing the root cause.
There was a problem hiding this comment.
First line is because the sevenZip converter has "any input" enabled, which causes slow routing if the input is some non-image and the output is an image archive. While I could split the converter in two such that there's a separate, image input–only converter for compiling image archives, that'd be a lot of duplicated code. The second line looking back is probably redundant with lines 72-75, so I'll remove it.
2 participants
Various changes made for the sake of simpler and more expected conversion between archive formats.