Skip to content

Add support for JSON5,JSONC,YML,TOML,INI to and from JSON#576

Merged
p2r3 merged 4 commits intop2r3:masterfrom
Explosion-Scratch:config-files
Mar 25, 2026
Merged

Add support for JSON5,JSONC,YML,TOML,INI to and from JSON#576
p2r3 merged 4 commits intop2r3:masterfrom
Explosion-Scratch:config-files

Conversation

@Explosion-Scratch
Copy link
Copy Markdown
Contributor

I just called this config.ts but I'm aware that #562 also is working on something similar, maybe I should rename to somthing else but I'm unsure what as these file formats are mainly used for configuration.

@p2r3
Copy link
Copy Markdown
Owner

p2r3 commented Mar 25, 2026

  • If you see that someone is already working on something similar to what you're working on, don't just remake the same thing from scratch?? If the other pull request gets merged, yours will just get closed due to being mostly a duplicate. If your pull request gets merged instead, then that's disrespectful to the author of the first one. I get that you've added more stuff in general, but you could've just waited a bit for the first PR to merge and worked on top of that.
  • Your CSS pull request is on the same branch as this one, so you've dragged the commit from that into this. This not only makes the CSS PR redundant, it also bleeds the scope of this one.

Lucky for you, it seems #562 has made some strange choices, so I do feel like I'd rather merge your implementation instead. I also don't see any issues with your CSS handler, so I'm fine with merging that here. This 🤏 close to closing, though.

@p2r3 p2r3 merged commit 9e5c049 into p2r3:master Mar 25, 2026
1 check failed
@p2r3 p2r3 mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants