Desktop: Don't include node_modules in app.asar#588
Open
exurd wants to merge 1 commit intop2r3:masterfrom
Open
Desktop: Don't include node_modules in app.asar#588exurd wants to merge 1 commit intop2r3:masterfrom
node_modules in app.asar#588exurd wants to merge 1 commit intop2r3:masterfrom
Conversation
since we're using vite, including this was pretty stupid. oops! i'm sorry to those who had to deal with big app sizes (that includes myself). 831.2 mb to 444.8 mb. 386.4 mb saved! ╰( ^o^)╮
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're using Vite (which bundles everything) this folder doesn't need to be included.
Tested this by building the Mac app; this reduces the total size from 831.2 mb to 444.8 mb. 386.4 mb saved!