Better HTML to SVG, and lossless HTML to PDF via Typst#589
Open
Explosion-Scratch wants to merge 1 commit intop2r3:masterfrom
Open
Better HTML to SVG, and lossless HTML to PDF via Typst#589Explosion-Scratch wants to merge 1 commit intop2r3:masterfrom
Explosion-Scratch wants to merge 1 commit intop2r3:masterfrom
Conversation
Contributor
Author
|
Here is what the demo word document turns into! |
Contributor
Author
This now works because our SVGs don't have foreignObjects because we're using the new htmlToSvg.ts
Explosion-Scratch
force-pushed
the
svg-typst-pdf
branch
from
03b4a7a to
3c83fdc
Compare
Contributor
Author
|
I'm not sure why tests are failing - they work locally. Maybe a cache thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML to SVG handler now uses this library to convert DOM to SVG (which works impressively well), then SVGs can be embedded into Typst to create vector PDFs!