Skip to content

Add Ninja to p4pi images and run image-build workflow on pull requests#95

Draft
fruffy with Copilot wants to merge 17 commits into
masterfrom
copilot/fix-ninja-build-error
Draft

Add Ninja to p4pi images and run image-build workflow on pull requests#95
fruffy with Copilot wants to merge 17 commits into
masterfrom
copilot/fix-ninja-build-error

Conversation

Copilot AI commented Apr 24, 2026

Copy link
Copy Markdown
  • Verify latest CI failure and confirm exact failing URL from logs
  • Audit all stage3 OBS repository/key URLs and test each Release.key endpoint
  • Confirm currently published OBS repositories and package availability for /home/runner/work/p4pi/p4pi/pi-gen/stage3/01-p4pi/01-packages
  • Remove invalid home:/p4pi/Raspbian_11 repository/key configuration from /home/runner/work/p4pi/p4pi/pi-gen/stage3/01-p4pi/00-run.sh
  • Remove packages that are unavailable from currently published repositories in /home/runner/work/p4pi/p4pi/pi-gen/stage3/01-p4pi/01-packages
  • Validate shell syntax and verify remaining package names are present in active OBS package indexes
  • Run Code Review + CodeQL validation

Copilot AI linked an issue Apr 24, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix ninja build error for P4 program compilation Add Ninja to p4pi images and run image-build workflow on pull requests Apr 24, 2026
Copilot AI requested a review from fruffy April 24, 2026 01:48
@chreekat

chreekat commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@fruffy the package is available now!

I made some progress on https://github.com/chreekat/p4pi/tree/copilot/fix-ninja-build-error (you can just merge the changes into this branch, or I can push them if you want). I'm done for the night right now, but a second CI run is currently ongoing over there.

@fruffy

fruffy commented Jul 9, 2026

Copy link
Copy Markdown

@fruffy the package is available now!

I made some progress on https://github.com/chreekat/p4pi/tree/copilot/fix-ninja-build-error (you can just merge the changes into this branch, or I can push them if you want). I'm done for the night right now, but a second CI run is currently ongoing over there.

Yes, feel free to push here.

@chreekat

Copy link
Copy Markdown
Contributor

Ah, the p4pi build also depends on a third OBS project that also builds bmv2, p4c, and pi. https://build.opensuse.org/project/show/home:p4edge:p4lang-testing. It produces aarch64 Raspbian binaries.

home:p4lang doesn't produce binaries for that distro yet, so the next step is to give it that capability. Hopefully it will be a simple borrowing of ideas from p4edge:p4lang-testing...

@chreekat

Copy link
Copy Markdown
Contributor

Plot twist: the aarch64 raspbian binaries showed up wizard-style, "precisely when they meant to".

https://download.opensuse.org/repositories/home:/p4lang/Raspbian_11/

The problem is that the p4c build failed, which p4pi still needs. Gotta look into that.

@chreekat

Copy link
Copy Markdown
Contributor

@fruffy my mistake -- I can't push to this repo cause I'm not a maintainer here.

You can pull in this branch to get past the expired signature issue: https://github.com/chreekat/p4pi/tree/copilot/fix-ninja-build-error

I've got Raspbian builds in home:p4lang now!

CI still doesn't pass, but the problems are further down the path.

Copilot AI and others added 12 commits July 18, 2026 14:33
…ompile stub scripts

Agent-Logs-Url: https://github.com/p4lang/p4pi/sessions/d88c31a0-8938-4c1b-b5fe-d927c01fb0a0

Co-authored-by: fruffy <5960321+fruffy@users.noreply.github.com>
Right now I'm just getting legitimate failures, which makes CI take
significantly longer for no benefit.
I use 'act' to run GitHub workflows locally. I also use submodules for
all my upstream checkouts. 'act' copies the working tree to a temp dir,
breaking the link to the "real" git dir. As a consequence, "git
rev-parse" fails.
I've folded in the Raspbian builds into home:p4lang, fixing the issue of
expired signatures.
@fruffy
fruffy force-pushed the copilot/fix-ninja-build-error branch from fbb8957 to 96ce0a2 Compare July 18, 2026 12:33
@fruffy

fruffy commented Jul 18, 2026

Copy link
Copy Markdown

@fruffy my mistake -- I can't push to this repo cause I'm not a maintainer here.

You can pull in this branch to get past the expired signature issue: https://github.com/chreekat/p4pi/tree/copilot/fix-ninja-build-error

I've got Raspbian builds in home:p4lang now!

CI still doesn't pass, but the problems are further down the path.

Feel free to also just squash or create an alternate PR. We can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not compile p4 program - Ninja error

3 participants