Refine mouse button shortcut toggles#164
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
WalkthroughThis PR refactors ShortcutView's trigger UI to use flexible grid layouts instead of fixed-width stacks. The keyboard and mouse trigger rows now share a LazyVGrid-based layout with flexible column definitions. The ShortcutRecorderView expands to fill available width, and keyboard enablement visuals are simplified. The mouse button picker is rewritten to support only left/right selection, backed by two new helper functions that centralize selection state logic and enforce constraints. Window width is reduced by 20 points, and trigger error handling is generalized to a common API. Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary
MouseButton.bothbehavior and saved preference compatibilityValidation
xcodebuild -project "Swift Shift.xcodeproj" -scheme "Swift Shift" -configuration Debug build.agents/skills/screenshots/bin/capture-swiftshift-screenshots.shSummary by CodeRabbit