add renderLastLine method to overriding if it need#71
Open
thykos wants to merge 1 commit intopablosichert:masterfrom
Open
add renderLastLine method to overriding if it need#71thykos wants to merge 1 commit intopablosichert:masterfrom
renderLastLine method to overriding if it need#71thykos wants to merge 1 commit intopablosichert:masterfrom
Conversation
thykos
force-pushed
the
renderLastLine
branch
from
8b3854b to
98f2838
Compare
Contributor
|
@thykos does the change with |
Author
yes, if we use linkify and last line include link, link will be cutted and broken. With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use this component to truncating a text, and I need to use
react-linkifyinside. I can override renderLine for this goals, but I noticed that last line rendered with broken link, because of slicing text.