video_volume.js will keep all the players volume in sync#166
Open
Znuff wants to merge 5 commits intopablouser1:masterfrom
Open
video_volume.js will keep all the players volume in sync#166Znuff wants to merge 5 commits intopablouser1:masterfrom
video_volume.js will keep all the players volume in sync#166Znuff wants to merge 5 commits intopablouser1:masterfrom
Conversation
this will also save the video player volume between sessions
pablouser1
requested changes
Sep 27, 2023
| services: | ||
| web: | ||
| container_name: proxitok-web | ||
| image: ghcr.io/pablouser1/proxitok:master |
Owner
There was a problem hiding this comment.
You should let docker-compose use the pre-built image, maybe you were doing some testing and forgot to undo it?
Author
There was a problem hiding this comment.
Obviously, how else could I test? It's just Github automatically picking up the docker-compose changes, this wasn't meant to make it in the PR
| - no-new-privileges:true | ||
| cap_drop: | ||
| - ALL | ||
| #cap_drop: |
Owner
There was a problem hiding this comment.
Why are you commenting out this?
Author
There was a problem hiding this comment.
It was breaking the Apache container previously. Again, the docker-compose.yml wasn't meant to be included in the PR.
Owner
|
Ok, make a commit undoing those temporary changes and I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will also save the video player volume between sessions
It's entirely possible that there's a better place somewhere else to include the script, but I'm not sure what's a better choice.