Remove biopython dependency, use .fai indexing with pyfaidx#24
Open
mdshw5 wants to merge 5 commits intopachterlab:masterfrom
Open
Remove biopython dependency, use .fai indexing with pyfaidx#24mdshw5 wants to merge 5 commits intopachterlab:masterfrom
mdshw5 wants to merge 5 commits intopachterlab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sharing your analysis. I plan on using this in the new year, and noticed that running the pre-processing scripts on our shared HPC cluster resulting in some permissions issues for shared reference genome assemblies. The issue is that
pyfastacreates its own index sidecar files, and fails if the user cannot write to the shared resource directory. I've swapped out pyfasta for my pyfaidx module, which will read or create a samtools .fai index file, which is likely already present in such a scenario. This also allowed me to drop the biopython dependency, as pyfaidx has a FASTA wrapping function.The output on the example dataset is identical using the code in this PR vs the current master branch.