Skip to content

Display multiple Copr builds for TF results if present#191

Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:tf-more-builds
Sep 29, 2022
Merged

Display multiple Copr builds for TF results if present#191
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:tf-more-builds

Conversation

@lbarcziova
Copy link
Copy Markdown
Member

@lbarcziova lbarcziova commented Sep 29, 2022

In packit/packit-service#1658 there was implemented that a TF run can be triggered with multiple Copr builds and API for TF runs changed (copr_build_id -> copr_build_ids) as well. This PR implements displaying those builds correctly in the TF result view.

Related to packit/packit-service#1658

The view for the TF runs with only one build stays the same and this is how it looks like for TF runs with more builds:
Snímka obrazovky z 2022-09-29 14-03-18


RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 19s

In packit/packit-service#1658 there was implemented that a TF run can be triggered with multiple
Copr builds and API for TF runs changed (copr_build_id -> copr_build_ids) as well.
This PR implements displaying those builds correctly in the TF result view.
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 44s

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 1m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aac3d2d into packit:main Sep 29, 2022
@lachmanfrantisek
Copy link
Copy Markdown
Member

lachmanfrantisek commented Sep 30, 2022

I know I am a bit late to the party, but can't we add more info to the labels? The numbering does not have any real meaning...
(I really like that you've changed the visual style from the pure text.)

What about something like this?
Screenshot from 2022-09-30 15-01-47

Or maybe even with the numbers to be explicit?
Screenshot from 2022-09-30 15-02-48

Or use this syntax just with the extra build but that could complicate things.

@mfocko Do you know what is the difference between this and pipelines that we've lost the space between the labels?

@lachmanfrantisek
Copy link
Copy Markdown
Member

And I've forgotten to mention that this whole feature is really amazing! 🚀

@mfocko
Copy link
Copy Markdown
Member

mfocko commented Sep 30, 2022

@lachmanfrantisek I think that in pipelines it's wrapped one more time in LabelGroup 🤔

@lbarcziova
Copy link
Copy Markdown
Member Author

@lachmanfrantisek the reason why I didn't want to do it that way was that it would require an additional API call since in the response for TF model we get only Copr build IDs. I was thinking about displaying the IDs instead of Build 1, 2, but on the other hand, the Copr build IDs are IDs in our DB which also does not make that much sense to show. Do you think it is worth it to do additional API calls/ changing the API so that we can display the PR number for the additional build (since you can see more info about the build right after clicking on the link for the build)?

@lbarcziova lbarcziova deleted the tf-more-builds branch October 3, 2022 06:20
@lachmanfrantisek
Copy link
Copy Markdown
Member

lachmanfrantisek commented Oct 5, 2022

I am not sure if it is worth that extra call... Personally, it sounds logical to know what are these builds about and which one is the core one and which one is the extra one (what we don't know here without other calls, do we?). But we can leave it as is and see if anyone will ask for it...

@TomasTomecek
Copy link
Copy Markdown
Member

Can we enhance the existing API call so it includes the additional info and we wouldn't need to perform extra API calls?

@mfocko
Copy link
Copy Markdown
Member

mfocko commented Oct 5, 2022

why does the page load for so long /o\ :peek:

@lbarcziova
Copy link
Copy Markdown
Member Author

Can we enhance the existing API call so it includes the additional info and we wouldn't need to perform extra API calls?

It is an option (as I already wrote in the previous comment - changing the API), but the additional processing would be still there, just directly in the packit-service code and I'm not sure I like that kind of API design. I would wait for some feedback and we can revisit/even discuss on arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants