nix-shell support and fix shebangs#656
nix-shell support and fix shebangs#656softwarefactory-project-zuul[bot] merged 5 commits intopackit:mainfrom
Conversation
mfocko
force-pushed
the
chore/nixpkg-direnv-support
branch
from
21f58bf to
7ca7e9b
Compare
|
Build failed. ❌ pre-commit FAILURE in 1m 27s |
mfocko
force-pushed
the
chore/nixpkg-direnv-support
branch
from
7ca7e9b to
7c3f1ea
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 26s |
mfocko
force-pushed
the
chore/nixpkg-direnv-support
branch
from
7c3f1ea to
f0ba510
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 27s |
|
could you please provide a bit more context for nix-shell support in the commit message? Personally I am not familiar with the setup, so might be useful also for others. |
Signed-off-by: Matej Focko <mfocko@packit.dev>
When specifying `bash` in the shebang, do not assume that it is present in the `/usr/bin`. Even better way would be `/bin/sh` that is guaranteed to be a symlink to POSIX-compatible shell, but I haven't checked the scripts whether they are POSIX-comaptible themselves. Signed-off-by: Matej Focko <mfocko@packit.dev>
mfocko
force-pushed
the
chore/nixpkg-direnv-support
branch
from
f0ba510 to
e156929
Compare
for more information, see https://pre-commit.ci
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 33s |
Signed-off-by: Matej Focko <mfocko@packit.dev>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
majamassarini
left a comment
majamassarini
left a comment
There was a problem hiding this comment.
LGTM
Feel free to ignore my suggestion (your point 3. already says how the environment is loaded).
Co-authored-by: Maja Massarini <2678400+majamassarini@users.noreply.github.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 35s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 35s |
softwarefactory-project-zuul
bot
merged commit 3cd7c2b
into
packit:main
3 participants
Related to packit/private#46