Fix a typo in the failure message#1762
Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom Nov 21, 2022
Merged
Fix a typo in the failure message#1762softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
Conversation
Contributor
Author
|
I have used github.dev to open this PR. What a terrible experience. (Sorry for the rant) |
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 57s |
lbarcziova
approved these changes
Nov 21, 2022
Member
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
Thanks!! Please, rebase and we can merge this
Contributor
Author
|
Oh, I clicked the |
This comment was marked as outdated.
This comment was marked as outdated.
A typo was introduced in packit#1658 where the `namespace` and `repo` were in the wrong order. Also removed the parameter `url` as the default value for `url` in `report_status_to_tests` is already an empty string.
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 51s |
Contributor
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 49s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo was introduced in #1658 where the
namespaceandrepowere in the wrong order.Also removed the parameter
urlas the default value forurlinreport_status_to_testsis already an empty string.