Skip to content

Return trigger information along with Log Detective run results#3081

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:return_build_info
Mar 31, 2026
Merged

Return trigger information along with Log Detective run results#3081
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:return_build_info

Conversation

@jpodivin
Copy link
Copy Markdown
Contributor

RELEASE NOTES BEGIN

Log Detective list API endpoint now returns information about triggering event, if such are available.

RELEASE NOTES END

Tests were expanded to account for the new datastructure.

@jpodivin jpodivin requested a review from a team as a code owner March 30, 2026 11:26
@jpodivin jpodivin requested review from betulependule and removed request for a team March 30, 2026 11:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the Log Detective API by including project-specific information in the result list. The API now updates the result dictionary with details such as pull request IDs, branch names, and project URLs retrieved from the build model. Correspondingly, the OpenShift API tests have been updated to verify the presence and correctness of these new fields in the response. I have no feedback to provide as there are no review comments to evaluate.

@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@jpodivin jpodivin force-pushed the return_build_info branch from 26821f8 to 6f746ba Compare March 31, 2026 07:49
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

@lbarcziova lbarcziova added the mergeit Merge via Zuul label Mar 31, 2026
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit d7336fc into packit:main Mar 31, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Mar 31, 2026
@jpodivin jpodivin deleted the return_build_info branch March 31, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

Development

Successfully merging this pull request may close these issues.

3 participants