Skip to content

Revert "Check if sync_release PR should warn about koji_build triggering bug"#3084

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
nforro:koji-warning
Mar 30, 2026
Merged

Revert "Check if sync_release PR should warn about koji_build triggering bug"#3084
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
nforro:koji-warning

Conversation

@nforro
Copy link
Copy Markdown
Member

@nforro nforro commented Mar 30, 2026

This reverts commit c35b238.

Fixes #2537.

Merge before packit/packit#2708.

@nforro nforro requested a review from a team as a code owner March 30, 2026 19:15
@nforro nforro requested review from majamassarini and removed request for a team March 30, 2026 19:15
@nforro nforro moved this from New to In review in Packit pull requests Mar 30, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the logic and configuration related to the warn_about_koji_build_triggering_bug flag. The changes include removing the Koji build job check in the distgit handler, cleaning up the now-unused JobConfigTriggerType import, and updating multiple integration and unit tests to reflect the removal of this parameter. I have no feedback to provide.

@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

centosinfra-prod-github-app bot commented Mar 30, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/4ed6f63524bf4ac8b2e6861dd6632f69

✔️ pre-commit SUCCESS in 1m 50s
✔️ packit-service-tests SUCCESS in 3m 58s

@nforro nforro added the mergeit Merge via Zuul label Mar 30, 2026
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

centosinfra-prod-github-app bot commented Mar 30, 2026

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/dcac51041723497095de08d73f627cfd

✔️ pre-commit SUCCESS in 1m 54s

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 0fe7d76 into packit:main Mar 30, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Packit pull requests Mar 30, 2026
@nforro nforro deleted the koji-warning branch March 30, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@majamassarini majamassarini Awaiting requested review from majamassarini majamassarini is a code owner automatically assigned from packit/the-packit-team

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

Packit pull requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Koji builds not triggered in branches where a merge has been fast forward if there are multiple commits in the merge.

3 participants

@nforro @lbarcziova @usercont-release-bot