Skip to content

Add docs about running TF with builds from other PR#528

Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:tf-more-builds
Oct 4, 2022
Merged

Add docs about running TF with builds from other PR#528
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:tf-more-builds

Conversation

@lbarcziova
Copy link
Copy Markdown
Member

@lbarcziova lbarcziova commented Sep 19, 2022

@lbarcziova lbarcziova mentioned this pull request Sep 19, 2022
Merged
5 tasks
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Sep 19, 2022

Build succeeded.

✔️ pre-commit SUCCESS in 1m 20s
✔️ hugo SUCCESS in 1m 02s

TomasTomecek
TomasTomecek requested changes Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments on 11 lines doc change than on 1.7k line code change 🙈

My main point here is to explain the feature in more detail so that packaging beginners can understand the use case.

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Sep 19, 2022

Build succeeded.

✔️ pre-commit SUCCESS in 1m 24s
✔️ hugo SUCCESS in 1m 06s

@lbarcziova
Copy link
Copy Markdown
Member Author

lbarcziova commented Sep 19, 2022

More comments on 11 lines doc change than on 1.7k line code change 🙈

:D I was definitely more passionate about writing the code than the docs, so that may be the reason

My main point here is to explain the feature in more detail so that packaging beginners can understand the use case.

Sure, you are right, thanks for suggestions!

TomasTomecek
TomasTomecek approved these changes Sep 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!!

softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this pull request Sep 29, 2022
@softwarefactory-project-zuul
Merge pull request #1658 from lbarcziova/tf-more-builds
31b879e 
Implement triggering TF with build from other PR

TODO:

 Polish the code.
 Fix openshift tests.
 Improve doc-strings.
 Update or write new documentation in packit/packit.dev (packit/packit.dev#528).
 Update view of the TF results in dashboard (I will open a dashboard PR once this is in staging)

Fixes #1544
Since this is a bigger change, maybe we can try the pair-review if anyone would be interested :D

RELEASE NOTES BEGIN
We have added support for running the tests with Copr builds built by Packit in another pull request (in a different repository). You can read more about this feature in our documentation.
RELEASE NOTES END

Reviewed-by: Tomas Tomecek <tomas@tomecek.net>
Reviewed-by: Laura Barcziová <None>
Reviewed-by: Matej Focko <None>
@lbarcziova lbarcziova added the mergeit Merge via Zuul label Oct 4, 2022
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Oct 4, 2022

Build succeeded.

✔️ pre-commit SUCCESS in 1m 20s
✔️ hugo SUCCESS in 1m 02s

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Oct 4, 2022

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 1m 20s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1cbe118 into packit:main Oct 4, 2022
@lbarcziova lbarcziova deleted the tf-more-builds branch October 4, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lbarcziova @TomasTomecek