Fix. when add router to stacks in wrong in_array arguments#4
Open
Lupino wants to merge 1 commit intopagon:masterfrom
Lupino:master
Open
Fix. when add router to stacks in wrong in_array arguments#4Lupino wants to merge 1 commit intopagon:masterfrom Lupino:master
Lupino wants to merge 1 commit intopagon:masterfrom
Lupino:master
Conversation
Member
|
这里有一个问题需要考虑,通过配置放进去的 中间件 和通过 add 添加的会结构不同,在考虑把结构做一致。这个先放到这里。 |
Contributor
Author
加这个路由是会是所有的 router 实效,原因是没有把 $app->router 加到 stacks 上,如果能够确定 router 没有在 stacks 上,可以直接 append 上去,不需要那部分判断了。 |
Member
|
不会啊,我刚测试了下,没有问题。你是最新版么,这段判断是基于最终的数据结构来生成的。 只有没检测到 router 才会添加到最后。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.