chore: Upgrade bff from spring to quarkus#220
Open
giampiero-ferrara wants to merge 106 commits intomainfrom
Open
chore: Upgrade bff from spring to quarkus#220giampiero-ferrara wants to merge 106 commits intomainfrom
giampiero-ferrara wants to merge 106 commits intomainfrom
Conversation
giampiero-ferrara
requested review from
a team and
giulia-tremolada
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
giampiero-ferrara
had a problem deploying
to
dev-cd
GitHub Actions
Error
giampiero-ferrara
temporarily deployed
to
dev-ci
GitHub Actions
Inactive
giampiero-ferrara
temporarily deployed
to
dev-cd
GitHub Actions
Inactive
|
# Conflicts: # apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/config/OnboardingFunctionConfig.java # infra/resources/onboarding-functions/dev-pnpg/onboarding.tf # infra/resources/onboarding-functions/prod-ar/onboarding.tf # infra/resources/onboarding-functions/prod-pnpg/onboarding.tf # infra/resources/onboarding-functions/uat-ar/onboarding.tf # infra/resources/onboarding-functions/uat-pnpg/onboarding.tf
# Conflicts: # .github/workflows/call_release_app.yml # apps/onboarding-bff/connector/rest/src/main/java/it/pagopa/selfcare/onboarding/connector/OnboardingMsConnectorImpl.java # apps/onboarding-bff/connector/rest/src/test/java/it/pagopa/selfcare/onboarding/connector/OnboardingMsConnectorImplTest.java
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of Changes
onboarding-bffon Quarkus, aligned with thestructure used by other microservices.
clientpattern infavor of a proper service layer (
OnboardingService/OnboardingServiceImpl) outside theapipackage.grouped sections with comments, renamed
ms_core -> institution).iam,product,auth) and removed remaining unnecessary Spring remnants.config(same approach used iniam/product) and fixed BFF date deserialization issues.Log Injection) through centralized sanitization (OWASP Encode.forJava).integration_tests_onboarding_bff.yml;CucumberSuiteTest(sameconvention as other microservices);
maven-surefire- pluginexclude), soclean installdoes not run it automatically;pull-requests: writewhere notallowed in the reusable workflow chain.
Motivation and Context
This PR originates from the need to experimentally use an AI tool to perform a
migration of
onboarding-bfffrom Spring to Quarkus, while keeping functionalparity and repository standards.
During this migration experiment, a number of issues emerged and were
addressed in this work:
The PR also improves CI reliability by:
mismatch.
Overall goal: validate an AI-assisted migration path from Spring to Quarkus,
with human supervision and targeted corrections, aligned with the technical
and operational standards already adopted across the repository.
How Has This Been Tested?
troubleshooting.
OffsetDateTimedeserialization failures when timezone offset is missing.Screenshots (if appropriate):
N/A
Types of changes
to not work as expected)
Checklist:
AI-assisted development disclosure
This PR was implemented with AI model assistance and supervised by me end-to-
end.
I reviewed all proposed changes and applied targeted manual adjustments where
needed (application logic, security, configuration, and CI workflows) before
finalizing.