Rebase "feat: replace x-editable with HTMX for inline editing" + other minors#2909
Closed
ElLorans wants to merge 16 commits into
Closed
Rebase "feat: replace x-editable with HTMX for inline editing" + other minors#2909ElLorans wants to merge 16 commits into
ElLorans wants to merge 16 commits into
Conversation
ElLorans
force-pushed
the
feat/replace-xeditable-with-htmx-oren
branch
from
1353ba6 to
915c367
Compare
ElLorans
changed the title
Contributor
Author
|
Test pass, example works. I would move this rebase and updates to #2909, then merge to master. We can work from there to unlock either #2892 (which looks done to me except for x editable not working) or #2444. EDIT: not ready yet. |
ElLorans
changed the title
Contributor
Author
|
Now err msgs appear |
) * fix(sqla): coerce ARRAY element type in `conv_ARRAY` (closes #1724) `AdminModelConverter.conv_ARRAY` returned a `Select2TagsField` with no `coerce` callable, so every submitted value was cast via the default `text_type` and the resulting Python list was always `list[str]`. For a Postgres `ARRAY(Integer)` column that round-trip fails on save with column "x" is of type integer[] but expression is of type text[] (reported in #1724 in 2018 and still reproducible on `master` as of v2.2.0; the long-standing workaround in that thread is to subclass `Select2TagsField` and override `process_formdata` to call `int()` on each entry). --------- Co-authored-by: ElLorans <lorenzo.cerreta@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing #2847 was not straightforward for me, so I am trying here before working on the original branch