Send Flask signals for cache hits and misses#237
Open
alanhamlett wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 89.63% 85.36% -4.27%
==========================================
Files 20 21 +1
Lines 2499 2638 +139
==========================================
+ Hits 2240 2252 +12
- Misses 259 386 +127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
Hi, is this PR ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses Flask Signals to solve #220.
Adds 4 new signals:
flask_caching.cache_view_hitflask_caching.cache_view_missflask_caching.cache_memoize_hitflask_caching.cache_memoize_missSignals for
cache.getaren't needed because the library user knows the result.