Skip to content

Send Flask signals for cache hits and misses#237

Open
alanhamlett wants to merge 2 commits into
pallets-eco:mainfrom
alanhamlett:signals
Open

Send Flask signals for cache hits and misses#237
alanhamlett wants to merge 2 commits into
pallets-eco:mainfrom
alanhamlett:signals

Conversation

@alanhamlett

Copy link
Copy Markdown
Contributor

Uses Flask Signals to solve #220.

Adds 4 new signals:

  • flask_caching.cache_view_hit
  • flask_caching.cache_view_miss
  • flask_caching.cache_memoize_hit
  • flask_caching.cache_memoize_miss

Signals for cache.get aren't needed because the library user knows the result.

@codecov-io

codecov-io commented Mar 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #237 (e93be24) into master (bfe1c5d) will decrease coverage by 4.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   89.63%   85.36%   -4.27%     
==========================================
  Files          20       21       +1     
  Lines        2499     2638     +139     
==========================================
+ Hits         2240     2252      +12     
- Misses        259      386     +127     
Flag Coverage Δ
unittests 85.36% <100.00%> (-4.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_caching/__init__.py 88.65% <100.00%> (+0.36%) ⬆️
flask_caching/contrib/googlecloudstoragecache.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe1c5d...e93be24. Read the comment docs.

@sh4nks

sh4nks commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator

Hi, is this PR ready to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants