Skip to content

Update fr_FR translation#1128

Open
BLeQuerrec wants to merge 2 commits into
pallets-eco:mainfrom
BLeQuerrec:main
Open

Update fr_FR translation#1128
BLeQuerrec wants to merge 2 commits into
pallets-eco:mainfrom
BLeQuerrec:main

Conversation

@BLeQuerrec

Copy link
Copy Markdown

This translation uses a gender neutral variant for French.

@BLeQuerrec

Copy link
Copy Markdown
Author

Not sure if tests with hardcoded translations are still relevant or if those hardcoded values should also be edited.

@jwag956

jwag956 commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

Yes - I think they are valuable - and sorry that I used French as the test language!

Those tests make sure that we are really properly grabbing the correct file and properly configuring babel/pybabel.

If you would - please change the tests to match your changes.

Thanks

@BLeQuerrec BLeQuerrec force-pushed the main branch 4 times, most recently from 5fee2d6 to 5584210 Compare December 21, 2025 01:01
@codecov

codecov Bot commented Dec 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (2b05b49) to head (56eed48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          40       40           
  Lines        5008     5008           
=======================================
  Hits         4934     4934           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BLeQuerrec

Copy link
Copy Markdown
Author

OK, PR ready. Lint test still fails due to an outdated lib, but it is out of the scope of this PR.

Comment thread tests/test_two_factor.py
existing = (
"Veuillez saisir votre code d'authentification généré via: authentificateur"
)
existing = "Veuillez saisir votre code d'authentification généré avec : authentificateur"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing (flake8) because 2 lines are too long.....

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BLeQuerrec, to pass lint, for the first long line replace it with (to keep it under 88 characters per line):

existing = (
            "Veuillez saisir votre code d'authentification généré avec : authentificateur"
        )

There is another long line at test_two_factor.py line 1595:

tests/test_two_factor.py:1586:89: E501 line too long (97 > 88 characters)
tests/test_two_factor.py:1595:89: E501 line too long (106 > 88 characters)

After changing them you can check them locally with:

pre-commit run flake8 --all

@arielvb

arielvb commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Hi!

PRs #1185 and #1183 added new messages to translate, I would like to update Catalan and Spanish, should I wait until this is merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants