AI spam#927
Closed
aizu-m wants to merge 1 commit into
Closed
Conversation
|
This is not a problem for CSRF tokens at all. You can't find out the CSRF token for another user's session that way, so all you could do is trying it for your own session - but that's pointless, because you already have access to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both CSRF validators compare a secret token against attacker-supplied form data with
!=, which short-circuits and leaks a byte-by-byte timing oracle on the expected token; switchSessionCSRFand the baseCSRFtohmac.compare_digest(and stop treating a None/None pair as a match).